Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison predicate handling for != #5282

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

paoloq
Copy link
Contributor

@paoloq paoloq commented Apr 9, 2020

Description

Fix issue #5281.

Types of change

Bug fix.

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@paoloq paoloq changed the title Fix #5281 Fix issue 5281 Apr 9, 2020
@explosion-bot
Copy link
Collaborator

Hi @paoloq, thanks for your pull request! 👍 It looks like you haven't filled in the spaCy Contributor Agreement (SCA) yet. The agreement ensures that we can use your contribution across the project. Once you've filled in the template, put it in the .github/contributors directory and add it to this pull request. If your pull request targets a branch that's not master, for example develop, make sure to submit the Contributor Agreement to the master branch. Thanks a lot!

If you've already included the Contributor Agreement in your pull request above, you can ignore this message.

@svlandeg svlandeg added enhancement Feature requests and improvements feat / matcher Feature: Token, phrase and dependency matcher labels Apr 9, 2020
@svlandeg
Copy link
Member

Thanks for the PR, I think this would be a good additional feature to have!

@svlandeg svlandeg changed the title Fix issue 5281 Comparison predicate handling for != Apr 10, 2020
@honnibal honnibal merged commit 8ce408d into explosion:master Apr 14, 2020
@paoloq paoloq deleted the bugfix/matcher_5281 branch April 15, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / matcher Feature: Token, phrase and dependency matcher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants