Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up and fix alignment of landing cards #5317

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Conversation

ines
Copy link
Member

@ines ines commented Apr 16, 2020

Resolves #5311.

Description

Should fix the visual alignment of landing page boxes on certain platforms by making text box and button flex column elements so button is always at the bottom and text box takes up remaining space, regardless of how full it is.

Types of change

docs / website

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@ines ines added the docs Documentation and website label Apr 16, 2020
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally and with this PR it now properly aligns!

@svlandeg svlandeg merged commit b919844 into master Apr 20, 2020
@svlandeg svlandeg deleted the docs/landing-alignment branch April 20, 2020 18:35
ines added a commit that referenced this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation and website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misaligned GET STARTED button
2 participants