Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize TokenC.sent_start values for Matcher #5346

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Normalize TokenC.sent_start values for Matcher #5346

merged 1 commit into from
Apr 29, 2020

Conversation

adrianeboyd
Copy link
Contributor

@adrianeboyd adrianeboyd commented Apr 24, 2020 •
edited

Description

Normalize TokenC.sent_start values to booleans for the Matcher.

Fixes #5287.

Types of change

Bug fix.

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Normalize TokenC.sent_start values for Matcher
c99be8f 
Normalize TokenC.sent_start values to booleans for the `Matcher`.
@svlandeg svlandeg added bug Bugs and behaviour differing from documentation feat / matcher Feature: Token, phrase and dependency matcher labels Apr 24, 2020
@honnibal honnibal merged commit 3f43c73 into explosion:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / matcher Feature: Token, phrase and dependency matcher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Matcher with "SENT_START": False works differently with Sentencizer vs. dependency parser
3 participants
@adrianeboyd @honnibal @svlandeg