Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization of disabled 'base' components #6219

Merged
merged 1 commit into from Oct 7, 2020
Merged

Fix serialization of disabled 'base' components #6219

merged 1 commit into from Oct 7, 2020

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Oct 7, 2020 •
edited

Fixes #6140

Description

Bugfix for v2, ensuring that (disabled) pipeline components from a base model are added back to the meta.json after training.

Types of change

bug fix

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface training Training and updating models feat / serialize Feature: Serialization, saving and loading labels Oct 7, 2020
@svlandeg svlandeg mentioned this pull request Oct 7, 2020
Closed
@honnibal honnibal merged commit 241cd11 into explosion:master Oct 7, 2020
@svlandeg svlandeg deleted the bugfix/6140 branch October 8, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface feat / serialize Feature: Serialization, saving and loading training Training and updating models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tagger and parser disappear when NER is added to model
2 participants
@svlandeg @honnibal