Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move max_length check to nlp.make_doc() #6512

Merged
merged 1 commit into from Dec 8, 2020

Conversation

adrianeboyd
Copy link
Contributor

Description

Move max_length check to nlp.make_doc() so that's it's also checked for nlp.pipe().

Types of change

Enhancement?

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

Move max_length check to `nlp.make_doc()` so that's it's also checked
for `nlp.pipe()`.
@adrianeboyd adrianeboyd added enhancement Feature requests and improvements feat / pipeline Feature: Processing pipeline and components labels Dec 7, 2020
@honnibal honnibal merged commit e931d3f into explosion:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / pipeline Feature: Processing pipeline and components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants