Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_vectors should accept arbitrary space characters as word tokens #836

Merged
merged 4 commits into from
Feb 16, 2017
Merged

load_vectors should accept arbitrary space characters as word tokens #836

merged 4 commits into from
Feb 16, 2017

Conversation

raphael0202
Copy link
Contributor

Description

See #834.

Types of changes

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality to spaCy)
  • Breaking change (fix or feature causing change to spaCy's existing functionality)
  • Documentation (addition to documentation of spaCy)

Checklist:

  • My change requires a change to spaCy's documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@raphael0202 raphael0202 mentioned this pull request Feb 16, 2017
Closed
@ines
Copy link
Member

ines commented Feb 16, 2017

This looks good! And thanks for cleaning up the imports! 👍

@ines ines merged commit 7d8c9ee into explosion:master Feb 16, 2017
ines added a commit that referenced this pull request Feb 16, 2017
@ines
Revert "Merge pull request #836 from raphael0202/load_vectors (closes #…
ea05f78 
…834)"

This reverts commit 7d8c9ee, reversing
changes made to f6b69ba.
@raphael0202 raphael0202 deleted the load_vectors branch February 16, 2017 15:13
ines added a commit that referenced this pull request Feb 16, 2017
@ines
Revert "Revert "Merge pull request #836 from raphael0202/load_vectors (…
85d249d 
…closes #834)""

This reverts commit ea05f78.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raphael0202 @ines