Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityRuler improve disk load error message #9658

Merged
merged 7 commits into from
Nov 23, 2021

Conversation

DuyguA
Copy link
Contributor

@DuyguA DuyguA commented Nov 11, 2021

Description

Improve the error messages for bad .jsonl paths and bad directories.

Types of change

Minor enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added feat / matcher Feature: Token, phrase and dependency matcher feat / serialize Feature: Serialization, saving and loading feat / ux Feature: User experience, error messages etc. labels Nov 15, 2021
spacy/errors.py Outdated Show resolved Hide resolved
spacy/errors.py Outdated Show resolved Hide resolved
@svlandeg svlandeg added the enhancement Feature requests and improvements label Nov 23, 2021
@svlandeg svlandeg merged commit a7d7e80 into explosion:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / matcher Feature: Token, phrase and dependency matcher feat / serialize Feature: Serialization, saving and loading feat / ux Feature: User experience, error messages etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants