-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PromptNER based Chain-of-Thought prompting for span tasks #180
Conversation
…ab/cot-ner-integrate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there 🙂 The templates for the other span-based tasks need to be updated still.
… parsing of SpanReason
* use a default example for zero-shot NER/spancat COT tasks if none are provided * add test for no examples spancat COT * Fix tests. * Update filterwarnings. * Update RELExample factory. * Comment validator. * Attempt to fix pydantic macOS error. * Attempt to fix pydantic macOS error. * Update filterwarnings. --------- Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>
I think this is ready for a final once-over and running the external tests in the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still two unresolved conversations, can you have a look at those?
I'd also like us to run a few more tests on how v3 can be used as a substitute for v2, and which changes (if any) would be needed in e.g. the Dolly NER example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good, nice team effort all! 🙏
Had a few nits + one more important question about a phrasing in the NER template.
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
# Conflicts: # usage_examples/tests/test_usage_examples.py
Description
Implements Chain-of-Thought prompting for Span tasks
Based on https://arxiv.org/pdf/2305.15444.pdf
Example Usage:
Types of change
Feature
Checklist
tests
andusage_examples/tests
, and all new and existing tests passed. This includespytest
ran with--external
)