Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register llm_TASK factories #243

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Register llm_TASK factories #243

merged 6 commits into from
Aug 16, 2023

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Aug 4, 2023 •
edited
Loading

Description

Register llm_TASK factories for all available tasks.

Corresponding documentation PR

explosion/spaCy#12905

Types of change

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added the feat/task Feature: tasks label Aug 4, 2023
@rmitsch rmitsch self-assigned this Aug 4, 2023
@rmitsch rmitsch changed the title Register llm_TASK factories Register llm_TASK factories Aug 4, 2023
svlandeg
svlandeg reviewed Aug 9, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Can you finish this up by extending the test suite a bit and writing the documentation?

spacy_llm/tests/pipeline/test_llm.py Outdated Show resolved Hide resolved
spacy_llm/tasks/__init__.py Outdated Show resolved Hide resolved
spacy_llm/tests/pipeline/test_llm.py Show resolved Hide resolved
@rmitsch
Copy link
Collaborator Author

rmitsch commented Aug 11, 2023

Docs PR.

@svlandeg svlandeg added the Test external Run external tests label Aug 16, 2023
svlandeg
svlandeg approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will merge when the external tests go green.

@svlandeg svlandeg merged commit 6874426 into main Aug 16, 2023
21 checks passed
@svlandeg svlandeg deleted the feat/llm_X_factories branch August 16, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianeboyd adrianeboyd adrianeboyd left review comments

@svlandeg svlandeg svlandeg approved these changes

Assignees

@rmitsch rmitsch

Labels
feat/task Feature: tasks Test external Run external tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmitsch @adrianeboyd @svlandeg