Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use same default model #283

Merged
merged 8 commits into from
Sep 7, 2023
Merged

Consistently use same default model #283

merged 8 commits into from
Sep 7, 2023

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Sep 6, 2023

Description

Use the same default model for the llm factory and the llm_task factories, so that these are entirely equivalent:

llm = nlp.add_pipe("llm", config={"task": {"@llm_tasks": "spacy.NER.v3"}})

and

llm = nlp.add_pipe("llm_ner")

Corresponding documentation PR

NA

Types of change

fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the feat/model Feature: models label Sep 6, 2023
@svlandeg svlandeg marked this pull request as ready for review September 6, 2023 14:45
spacy_llm/pipeline/llm.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@rmitsch rmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment.

spacy_llm/pipeline/llm.py Outdated Show resolved Hide resolved
spacy_llm/tests/tasks/test_ner.py Show resolved Hide resolved
@rmitsch
Copy link
Collaborator

rmitsch commented Sep 7, 2023

Should succeed after merging in develop.

@svlandeg svlandeg merged commit 7c608e7 into develop Sep 7, 2023
11 checks passed
@svlandeg svlandeg deleted the fix/default_model branch September 7, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/model Feature: models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants