Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes custom endpoint usage for OpenAI models #429

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Jan 26, 2024

Description

Fixes custom endpoint usage for OpenAI models by removing a check for the endpoint to be one of the default endpoints.

Corresponding documentation PR

-

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added bug Something isn't working feat/model Feature: models Test external Run external tests labels Jan 26, 2024
@rmitsch rmitsch self-assigned this Jan 26, 2024
@rmitsch rmitsch linked an issue Jan 26, 2024 that may be closed by this pull request
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svlandeg svlandeg merged commit 09fcad1 into main Jan 26, 2024
23 checks passed
@svlandeg svlandeg deleted the fix/custom-endpoints branch January 26, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat/model Feature: models Test external Run external tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Custom Endpoint Validation Breaks Feature Support
2 participants