-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make resizable layer work with textcat and transformers #820
Merged
svlandeg
merged 4 commits into
explosion:master
from
polm:fix/resizable-initialized-check
Feb 22, 2023
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
import pytest | ||
from mock import MagicMock | ||
from functools import partial | ||
from hypothesis import given, settings | ||
import numpy | ||
from numpy.testing import assert_allclose | ||
from thinc.api import resizable, Linear, chain, Dropout, SGD | ||
from thinc.layers.resizable import resize_model, resize_linear_weighted | ||
|
||
from ..strategies import arrays_OI_O_BI | ||
from ..util import get_model, get_shape | ||
|
||
|
||
@pytest.fixture | ||
def model(): | ||
output_layer = Linear(nO=None, nI=None) | ||
fill_defaults = {"b": 0, "W": 0} | ||
model = resizable( | ||
output_layer, | ||
resize_layer=partial(resize_linear_weighted, fill_defaults=fill_defaults), | ||
) | ||
return model | ||
|
||
|
||
def test_resizable_linear_default_name(model): | ||
assert model.name == "resizable(linear)" | ||
|
||
|
||
def test_resize_model(model): | ||
"""Test that resizing the model doesn't cause an exception.""" | ||
resize_model(model, new_nO=10) | ||
resize_model(model, new_nO=11) | ||
|
||
model.set_dim("nO", 0, force=True) | ||
resize_model(model, new_nO=10) | ||
|
||
model.set_dim("nI", 10, force=True) | ||
model.set_dim("nO", 0, force=True) | ||
resize_model(model, new_nO=10) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find, Paul. Seems correct to me!