Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing "Loading" text after loading? #3

Open
kallewesterling opened this issue May 16, 2019 · 7 comments
Open

Removing "Loading" text after loading? #3

kallewesterling opened this issue May 16, 2019 · 7 comments

Comments

@kallewesterling
Copy link

Hello,

I couldn't find anything in the docs about how to get rid of the "Loading..." text fully after the loading is "finished"? I tried it in a Jupyter Notebook and this is the result:

image

Any suggestions?

@ines
Copy link
Member

ines commented May 16, 2019

Thanks for the report. It seems like in the notebook, the sequence used to erase a line and flush is somehow interpreted differently? Relevant code is here:

https://github.com/ines/wasabi/blob/2beb8fe98cdfe9cafcae0a7c7b18c9738119e337/wasabi/printer.py#L201-L202

I'd need to investigate this. The whole cursor movement stuff, erasing lines etc. is definitiely one of the trickier parts – at least, I've always found it kinda difficult to get right across platforms and configurations and there might still be cases where it fails.

@kallewesterling
Copy link
Author

I know!! I am so happy to have come across your package though! (Found it when I looked over the spaCy code!) I have had so much trouble with flushing... ugh.

@kallewesterling
Copy link
Author

I have looked into this issue myself now and cannot find a solution!

@kallewesterling
Copy link
Author

@ines do you think the newest release will help with this issue?

@ardyfeb
Copy link

ardyfeb commented Aug 2, 2020

@kallewesterling any solution ?

@kallewesterling
Copy link
Author

@ardyfeb I have nothing to do with the dev of this package. Ask @ines! :)

@kallewesterling
Copy link
Author

@ines Revisited this issue and it now looks like it works better, in a way. At last, the .good() message displays at the end of the loop:

image

However, the context manager does not generate any output in the Notebook. This is what it looks like when inside the with msg.loading() manager:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants