Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal of Layout #1

Closed
wants to merge 3 commits into from
Closed

Conversation

koaning
Copy link

@koaning koaning commented Oct 11, 2022

This is a PR so that @polm can give a review on the file structure. I tried to split the utilities from the spaCy library into separate files to make it somewhat easier to maintain. My approach is to work on one command at a time, but before doing any serious work it'd be good to get the foundation aligned.

This PR implements the clone command and I was able to run this locally without issue.

python -m weasel clone pipelines/tagger_parser_ud

I haven't added any tests yet, partially because I was wondering if we want to use Github actions (which I believe is free) or something else for that (Azure? I might need help to set that up).

@koaning koaning changed the title Proposal layout Proposal of Layout Oct 11, 2022
@polm
Copy link

polm commented Oct 12, 2022

Thanks for setting this up, this looks fine to me.

The util code in spaCy is huge, so it makes sense to split it up. This looks like it might be split a little too fine - do we need a _compat file? - but it's a good start and we can make adjustments as we find pain points in actual use.

@koaning
Copy link
Author

koaning commented Oct 12, 2022

Grand.

I'll chug along and keep adding features. Once there's a milestone I'll let you know :)

@koaning koaning closed this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants