Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for rocket fired event log #242

Open
Cooldude2606 opened this issue Aug 5, 2023 · 0 comments
Open

False positives for rocket fired event log #242

Cooldude2606 opened this issue Aug 5, 2023 · 0 comments
Labels
Bug Reporting/fixing a bug, error, or desync

Comments

@Cooldude2606
Copy link
Member

Factorio version
Version number: 1.1.87

Scenario version
Version number: 6.2.1

Bug description
There are a few cases of false positives for the rocket/nuke fired event in the decon log. The cause is because there is no "fired" event in factorio, rather we rely on on_player_ammo_inventory_changed which can be raised by equiping rockets for the first time or by switching between rockets and explosive rockets.

Reproduction method
Steps to reproduce the behavior:

  1. Have both rockets and explosive rockets in your inventory.
  2. Equip the rockets, this will emit an event in the log.
  3. Equip the explosive rockets in the same slot, this will raise another event in th log.
  4. Keep switching between the two, a new log line is added each time.

Expected behavior
Log events should only be emited when a rocket is fired.

@Cooldude2606 Cooldude2606 added the Bug Reporting/fixing a bug, error, or desync label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reporting/fixing a bug, error, or desync
Projects
None yet
Development

No branches or pull requests

1 participant