upgrade from Expo 46 to 49 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to change Readme after merge |
|
Thanks @deonneon! I will check this out and get back. |
amandeepmittal
requested changes
Mar 26, 2024
amandeepmittal
approved these changes
Mar 27, 2024
| persistence: getReactNativePersistence(AsyncStorage), | ||
| }); | ||
| // | ||
| // Need to upgrade to Expo with typescrip inorder getReactNativePersistence to work. |
There was a problem hiding this comment.
I will follow up this on quickly after merging this PR as I have changes to upgrade to SDK 50 stacked up.
There was a problem hiding this comment.
Upgraded to SDK 50 in #84 and tested this and it works without the need to use TypeScript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded template for 46 to 49.
Able to preserve JS First format. Firebase persistence Async Storage is broken. Will need to convert to TS format to be compatible with the react-native async library.
Any user working with an existing TypeScript project should be able to get the full benefit.