Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save QR code as png #82

Closed
wants to merge 1 commit into from

Conversation

abhisheksoni27
Copy link

@abhisheksoni27 abhisheksoni27 commented Mar 17, 2017

Fix: This saves the QR code as PNG, thereby helping people for whom the QR code logged in the terminal doesn't work. (#49)

Packages Added

@anp
Copy link
Contributor

anp commented Mar 17, 2017

Hi! Thanks so much for the PR!

I'm not in favor of this approach for two reasons:

  1. It creates noise on the user's file system
  2. The URL is not stable -- it will change if the user's IP address changes or if some process takes port 19000 or 19001, which may cause confusion especially if a user accidentally checks the PNG into git.

I think it'll be good to document troubleshooting and work on improving the reliability of the QR code that's displayed, but I don't want to write images to disk to do so.

@anp anp closed this Mar 17, 2017
@abhisheksoni27
Copy link
Author

Hey, thanks for the explanation!

Reason 2. made more sense to me. 🤔 That should have been my epiphany.

I'll think as to how the reliability of the QR code can be enhanced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants