-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli][eas-update] Add rollback disambiguation command #2004
Conversation
/changelog-entry new-feature Add rollback disambiguation command |
Size Change: +1.08 kB (0%) Total Size: 42.3 MB
|
Codecov Report
@@ Coverage Diff @@
## main #2004 +/- ##
==========================================
- Coverage 53.05% 53.02% -0.02%
==========================================
Files 507 508 +1
Lines 18405 18445 +40
Branches 3857 3869 +12
==========================================
+ Hits 9763 9779 +16
- Misses 7948 7971 +23
- Partials 694 695 +1
|
Note that there is an existing bug where updates of type "roll back to embedded" can be republished, though that seems incorrect. Will fix in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eas update:rollback
is a good idea. part of me wonders if we should just scrap update:republish
and provide a flag in update:rollback
for the power users to specify a republish or rollback-to-embedded
Need to hide this for now, until we launch roll-back-to-embedded. |
54e9ea4
to
463ef11
Compare
❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you. |
Why
As requested by @jonsamp:
And after consulting with people in the CLI sync meeting, we decided that it didn't make sense to try to combine the commands since they contain different sets of flags. But, we decided that there could be the best of both worlds:
eas update:republish
andeas update:roll-back-to-embedded
commands for power users and for non-interactive/json output.eas update:rollback
command for an interactive disambiguation command that routes to one of the other two based on a prompt.Closes ENG-9420.
How
Add disambiguation command, ability for
republish
command to be fully interactive (not need to provide any flags).Test Plan