Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli][eas-update] Support republishing roll back to embedded updates #2005

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

wschurman
Copy link
Member

Why

#2004 (comment)

When a roll back to embedded type update was republished, the code failed. This fixes it.

How

Support republishing signed roll-back-to-embedded updates.

Test Plan

$ neas update:rollback --private-key-path keys/private-key.pem
✔ Which type of update would you like to roll back to? › Published Update
✔ Find update by branch or channel? › Channel
✔ Select a channel to view › main
✔ Load more update groups? › [Aug 14 09:38 by wschurman, runtimeVersion: 1.0.0] rb
✔ The republished update group will appear only on: all
✔ Provide an update message. … Republish "rb" - group: c59d7422-0064-4fee-b14e-259517a223f0
✔ The republished update group will be signed

  • Republishing...
    🔒 Signing republished update group
  • Republishing...
    ✔ Republished update group

Branch main
Runtime version 1.0.0
Platform android, ios
Update group ID 0849f86f-5808-4c4d-8c08-f257998e235d
Android update ID e6266b29-07ff-4470-91e9-b8352b10dd3c
iOS update ID 894ba423-53a0-4564-afa7-d6362ebda3fb
Message Republish "rb" - group: c59d7422-0064-4fee-b14e-259517a223f0
Website link https://expo.dev/accounts/wschurman/projects/watwathuh/updates/0849f86f-5808-4c4d-8c08-f257998e235d

@wschurman wschurman requested review from quinlanj and removed request for byCedric and EvanBacon August 14, 2023 17:25
@wschurman
Copy link
Member Author

/changelog-entry bug-fix Support republishing roll back to embedded updates

@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Size Change: -219 B (0%)

Total Size: 42.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.3 MB -219 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2005 (198a328) into @wschurman/rollback-command (6cb63bb) will increase coverage by 0.01%.
Report is 1 commits behind head on @wschurman/rollback-command.
The diff coverage is 70.59%.

@@                       Coverage Diff                       @@
##           @wschurman/rollback-command    #2005      +/-   ##
===============================================================
+ Coverage                        53.02%   53.02%   +0.01%     
===============================================================
  Files                              508      508              
  Lines                            18430    18442      +12     
  Branches                          3862     3868       +6     
===============================================================
+ Hits                              9770     9777       +7     
- Misses                            7966     7970       +4     
- Partials                           694      695       +1     
Files Changed Coverage Δ
packages/eas-cli/src/update/republish.ts 84.00% <70.59%> (-4.88%) ⬇️

@wschurman wschurman merged commit 54e9ea4 into @wschurman/rollback-command Aug 15, 2023
9 checks passed
@wschurman wschurman deleted the @wschurman/rollback-command-2 branch August 15, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants