Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eas-cli] [ENG-7536] Stop app config error repeating #2020

Merged
merged 7 commits into from
Aug 30, 2023
Merged

[eas-cli] [ENG-7536] Stop app config error repeating #2020

merged 7 commits into from
Aug 30, 2023

Commits on Aug 25, 2023

  1. [eas-cli] Stop app config error repeating 

    If app config error is thrown it is re-thrown with modified message instead of printing it to the as a "cryptic error" and repeating with 0% chances of success (since the config is incorrect)

See: https://linear.app/expo/issue/ENG-7536/make-app-config-error-on-credentials-command-not-repeat-indefinitely
    @radoslawkrzemien
    radoslawkrzemien committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    f9ca5d1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into @radoslawkrzemien/ENG… 

    …-7536-make-app-config-error-not-repeat
    @radoslawkrzemien
    radoslawkrzemien committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    79e541e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. [eas-cli] Create custom error 

    Replaced generic error with specific message with a custom error class, which allows for not relying on a message to be exactly as expected

See: https://linear.app/expo/issue/ENG-7536/make-app-config-error-on-credentials-command-not-repeat-indefinitely
    @radoslawkrzemien
    radoslawkrzemien committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f4e4baa View commit details
    Browse the repository at this point in the history

  2. update CHANGELOG.md

    @radoslawkrzemien
    radoslawkrzemien committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8acc4d1 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into @radoslawkrzemien/ENG… 

    …-7536-make-app-config-error-not-repeat

# Conflicts:
#	CHANGELOG.md
    @radoslawkrzemien
    radoslawkrzemien committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d65a1bc View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Merge remote-tracking branch 'origin/main' into @radoslawkrzemien/ENG… 

    …-7536-make-app-config-error-not-repeat

# Conflicts:
#	CHANGELOG.md
    @radoslawkrzemien
    radoslawkrzemien committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    1f7efd7 View commit details
    Browse the repository at this point in the history

  2. [eas-cli] Remove blank line 

    Removed blank line from changelog

See: https://linear.app/expo/issue/ENG-7536/make-app-config-error-on-credentials-command-not-repeat-indefinitely
    @radoslawkrzemien
    radoslawkrzemien committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    4fae2d7 View commit details
    Browse the repository at this point in the history