[eas-cli] [ENG-7536] Stop app config error repeating #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If app config error is thrown it is re-thrown with modified message instead of printing it to the as a "cryptic error" and repeating with 0% chances of success (since the config is incorrect) See: https://linear.app/expo/issue/ENG-7536/make-app-config-error-on-credentials-command-not-repeat-indefinitely
radoslawkrzemien
requested review from
szdziedzic and
khamilowicz
as code owners
ENG-7536 Make app config error on credentials command not repeat indefinitely
Can only get out of it with CTRL+C, pressing a key just shows the error again. Bonus points for linking to something more relevant, like the app.config.js schema docs, instead of saying we thing our error is cryptic :) |
…-7536-make-app-config-error-not-repeat
|
Size Change: -437 B (0%) Total Size: 42.2 MB
|
Codecov Report
@@ Coverage Diff @@
## main #2020 +/- ##
==========================================
+ Coverage 53.32% 53.53% +0.22%
==========================================
Files 508 508
Lines 18530 18538 +8
Branches 3889 3891 +2
==========================================
+ Hits 9879 9923 +44
+ Misses 8632 8596 -36
Partials 19 19
|
szdziedzic
reviewed
Aug 28, 2023
Comment on lines
136
to
140
| err instanceof Error && | ||
| err.message === | ||
| `Specify "android.package" in ${getProjectConfigDescription( | ||
| ctx.projectDir | ||
| )} and run this command again.` |
There was a problem hiding this comment.
Is there any better way to determine if this is this specific error (not relying on a message)? 🤔 Ideally, it would be good to use an error code or sth like this.
What do you think?
There was a problem hiding this comment.
Thought about it, I can make a custom error class for that, probably the best option
Replaced generic error with specific message with a custom error class, which allows for not relying on a message to be exactly as expected See: https://linear.app/expo/issue/ENG-7536/make-app-config-error-on-credentials-command-not-repeat-indefinitely
|
/changelog-entry bug-fix Make app config error not repeat indefinitely |
…-7536-make-app-config-error-not-repeat # Conflicts: # CHANGELOG.md
szdziedzic
approved these changes
Aug 28, 2023
…-7536-make-app-config-error-not-repeat # Conflicts: # CHANGELOG.md
Removed blank line from changelog See: https://linear.app/expo/issue/ENG-7536/make-app-config-error-on-credentials-command-not-repeat-indefinitely
|
✅ Thank you for adding the changelog entry! |
radoslawkrzemien
deleted the
@radoslawkrzemien/ENG-7536-make-app-config-error-not-repeat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://linear.app/expo/issue/ENG-7536/make-app-config-error-on-credentials-command-not-repeat-indefinitely
How
If app config error is thrown it is re-thrown with modified message instead of printing it to the as a "cryptic error" and repeating with 0% chances of success (since the config is incorrect)
Test Plan
Added automated test
Tested manually:
The link from the message leads to the docs:
