-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] [ENG-10225] add requiredPackageManager to build metadata #2067
Conversation
ENG-10225 Ignore custom tools installation errors when the tool is not the preferred packager
Context: https://exponent-internal.slack.com/archives/C02123T524U/p1695688801287029 Steps to reproduce:
There are two tasks to make this happen:
|
Size Change: +60.9 kB (0%) Total Size: 42.6 MB
|
Codecov Report
@@ Coverage Diff @@
## main #2067 +/- ##
==========================================
- Coverage 54.07% 54.06% -0.00%
==========================================
Files 508 508
Lines 18638 18641 +3
Branches 3721 3722 +1
==========================================
+ Hits 10076 10077 +1
- Misses 8542 8544 +2
Partials 20 20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, one comment:
Also one reminder: remember to update dependencies in turtle-v2
before deploying it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀 . Thanks!
✅ Thank you for adding the changelog entry! |
Why
We want to know what the user's package manager is going to be at the "install custom tools" step of the build process, so we're determining it based on the user's lockfiles and adding it to build metadata.
eas-build-job
[eas-build-job] [ENG-10225] add requiredPackageManager to build metadata eas-build#281www
https://github.com/expo/universe/pull/13522eas-cli
[eas-cli] [ENG-10225] add requiredPackageManager to build metadata #2067turtle-v2
https://github.com/expo/turtle-v2/pull/1460How
Added the field.
Test Plan
Unit tests and building locally.