Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-11090][eas-cli] prompt users if they want to continue if provisioning the devices fails #2181

Conversation

szdziedzic
Copy link
Member

Why

https://linear.app/expo/issue/ENG-11090/prompt-user-whether-they-want-to-continue-if-we-fail-to-provision

How

Prompt users if they want to continue if we fail to provision the devices

Test Plan

(Yeah I know it says 0, I commented out the if statement to test it)
Screenshot 2024-01-16 at 10 57 13
Screenshot 2024-01-16 at 10 54 42

@szdziedzic
Copy link
Member Author

/changelog-entry chore Prompt users if they want to continue if EAS CLI fails to provision the devices

Copy link

github-actions bot commented Jan 16, 2024

Size Change: +1.63 kB (0%)

Total Size: 55.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 55.5 MB +1.63 kB (0%)

compressed-size-action

@szdziedzic szdziedzic force-pushed the @szdziedzic/prompt-users-if-they-want-to-continue-without-porvisioning-devices branch from c7ffe59 to efa6c34 Compare January 16, 2024 10:08
Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (189d163) 54.23% compared to head (307062b) 54.23%.

Files Patch % Lines
...tials/ios/actions/SetUpAdhocProvisioningProfile.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
+ Coverage   54.23%   54.23%   +0.01%     
==========================================
  Files         509      509              
  Lines       18660    18664       +4     
  Branches     3737     3738       +1     
==========================================
+ Hits        10118    10121       +3     
- Misses       8521     8522       +1     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@radoslawkrzemien radoslawkrzemien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@szdziedzic szdziedzic merged commit 4c07b89 into main Jan 16, 2024
9 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/prompt-users-if-they-want-to-continue-without-porvisioning-devices branch January 16, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants