-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] [ENG-11310] Don't require expo on fresh react-native project #2235
[eas-cli] [ENG-11310] Don't require expo on fresh react-native project #2235
Conversation
Do not require expo to be installed and configured for a fresh react-native project See: https://linear.app/expo/issue/ENG-11310/fix-warnings-errors-that-come-up-when-adding-eas-to-a-react-native-cli
Size Change: +286 B (0%) Total Size: 51.3 MB
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
==========================================
- Coverage 54.04% 54.03% -0.01%
==========================================
Files 519 519
Lines 18921 18927 +6
Branches 3789 3791 +2
==========================================
+ Hits 10224 10225 +1
- Misses 8676 8681 +5
Partials 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
/changelog-entry bug-fix Don't require expo on fresh react-native project |
Forgot to rethrow other types of errors See: https://linear.app/expo/issue/ENG-11310/fix-warnings-errors-that-come-up-when-adding-eas-to-a-react-native-cli
✅ Thank you for adding the changelog entry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging by the tests you've performed, it looks like it fixes the issue.
Why
https://linear.app/expo/issue/ENG-11310/fix-warnings-errors-that-come-up-when-adding-eas-to-a-react-native-cli
How
When Expo config error is thrown while initiating a project only a warning message is printed instead of throwing an error and failing the command
Test Plan
Automatic tests
All tests pass
Manual tests
Before
eas init
After
eas init
eas build -p ios --auto-submit