Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] [ENG-11310] Don't require expo on fresh react-native project #2235

Conversation

radoslawkrzemien
Copy link
Contributor

Why

https://linear.app/expo/issue/ENG-11310/fix-warnings-errors-that-come-up-when-adding-eas-to-a-react-native-cli

How

When Expo config error is thrown while initiating a project only a warning message is printed instead of throwing an error and failing the command

Test Plan

Automatic tests

All tests pass

Manual tests

Before

eas init
Screenshot 2024-02-19 at 14 36 36

After

eas init
Screenshot 2024-02-19 at 14 37 45
eas build -p ios --auto-submit
Screenshot 2024-02-19 at 14 40 39

Copy link

github-actions bot commented Feb 19, 2024

Size Change: +286 B (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB +286 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e157473) 54.04% compared to head (0a24a6d) 54.03%.

Files Patch % Lines
packages/eas-cli/src/commands/project/init.ts 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2235      +/-   ##
==========================================
- Coverage   54.04%   54.03%   -0.01%     
==========================================
  Files         519      519              
  Lines       18921    18927       +6     
  Branches     3789     3791       +2     
==========================================
+ Hits        10224    10225       +1     
- Misses       8676     8681       +5     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@radoslawkrzemien
Copy link
Contributor Author

/changelog-entry bug-fix Don't require expo on fresh react-native project

Copy link

✅ Thank you for adding the changelog entry!

Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by the tests you've performed, it looks like it fixes the issue.

@radoslawkrzemien radoslawkrzemien merged commit 9bf1f38 into main Feb 19, 2024
9 checks passed
@radoslawkrzemien radoslawkrzemien deleted the @radoslawkrzemien/ENG-11310-cli-fix-errors-when-adding-eas-to-react-native-cli branch February 19, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants