Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eas-cli] [ENG-11310] Don't require expo on fresh react-native project #2235

Merged
merged 3 commits into from
Feb 19, 2024
Merged

[eas-cli] [ENG-11310] Don't require expo on fresh react-native project #2235

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5046daf
[eas-cli] Don't require expo
radoslawkrzemien Feb 19, 2024
3721b44
update CHANGELOG.md
radoslawkrzemien Feb 19, 2024
0a24a6d
[eas-cli] Throw other errors
radoslawkrzemien Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/eas-cli/src/commands/project/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { getProjectConfigDescription } from '@expo/config';
import { ConfigError, getProjectConfigDescription } from '@expo/config';
import { ExpoConfig } from '@expo/config-types';
import { Flags } from '@oclif/core';
import chalk from 'chalk';
Expand Down Expand Up @@ -60,7 +60,17 @@ export default class ProjectInit extends EasCommand {
projectDir: string,
modifications: Partial<ExpoConfig>
): Promise<void> {
const result = await createOrModifyExpoConfigAsync(projectDir, modifications);
let result;
try {
result = await createOrModifyExpoConfigAsync(projectDir, modifications);
} catch (error) {
if (error instanceof ConfigError && error.code === 'MODULE_NOT_FOUND') {
Log.warn(
'Cannot determine which native SDK version your project uses because the module `expo` is not installed.'
);
}
return;
}
switch (result.type) {
case 'success':
break;
Expand Down
Loading