[eas-cli] Use expo-updates runtime version CLI to generate runtime versions #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2.64 kB (0%) Total Size: 51.3 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2251 +/- ##
==========================================
+ Coverage 54.02% 54.05% +0.03%
==========================================
Files 519 520 +1
Lines 18935 18953 +18
Branches 3798 3805 +7
==========================================
+ Hits 10228 10243 +15
- Misses 8686 8689 +3
Partials 21 21 ☔ View full report in Codecov by Sentry. |
wschurman
force-pushed
the
@wschurman/include-build-in-search
branch
from
057d5ee
to
d75380a
Compare
wschurman
force-pushed
the
@wschurman/runtime-version-cli
branch
from
bdb7cb0
to
edaa89f
Compare
wschurman
force-pushed
the
@wschurman/runtime-version-cli
branch
from
edaa89f
to
0fbfd1f
Compare
wschurman
requested review from
szdziedzic,
khamilowicz and
sjchmiela
as code owners
wschurman
requested review from
quinlanj and
douglowder
and removed request for
sjchmiela and
khamilowicz
|
/changelog-entry bug-fix Use expo-updates runtime version CLI to generate runtime versions |
|
✅ Thank you for adding the changelog entry! |
quinlanj
approved these changes
Feb 28, 2024
szdziedzic
approved these changes
Feb 28, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This makes use of expo/expo#27263 to generate the correct runtime version for build metadata and updates.
How
Call the command in the package to use the versioned config-plugins for the app. This way the runtime version is consistent no matter what version of eas-cli is used (and for canary versions so we don't have to update eas-cli to use canaries).
Test Plan
Run tests.
Manual test:
neas buildwith a bare-app in expo/exponeas updatewith same app, including withEXPO_DEBUG=1to see fingerprint sources.