[build-tools] Update expo-updates runtime version resolution #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping |
quinlanj
approved these changes
Mar 4, 2024
wschurman
added a commit
that referenced
this pull request
Mar 6, 2024
wschurman
added a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Same as expo/eas-cli#2251 but for build-tools. This issue (using a single version of config plugins to execute updates related logic rather than the version of config plugins the app uses) seems to be pretty widespread.
This PR applies the same strategy: call into the app versioned expo-updates CLI to resolve runtime version (if possible, falling back to single version config plugins for now).
How
Copy paste code.
Test Plan
~/expo/run-with-local-eas-build.sh build --local, see runtime version is consistently resolved.