[@eas/config] add library #3

wkozyra95 · 2020-09-14T15:10:39Z

No description provided.

wkozyra95 · 2020-09-14T15:12:35Z

packages/eas-cli/src/commands/login.ts

@@ -8,6 +9,7 @@ export default class Login extends Command {

  async run() {
    this.log('Log in to EAS');
+    await new EasJsonReader(process.cwd(), 'all').readAsync('release');


This is just to make sure that imports work

fson

Thanks! The overall structure of the library seems fine. 👍

Added a few other comments about the draft PR below.

fson · 2020-09-15T13:20:23Z

packages/config/src/__tests__/easJson-test.ts

+
+jest.mock('fs-extra');
+
+describe('eas.json', () => {


You can omit the describe block and indentation and put tests in the top level of this file, as there is only one group of tests in this file.

fson · 2020-09-15T13:35:40Z

packages/config/src/index.ts

+  private validateBuildProfile<T extends BuildProfile>(
+    platform: 'android' | 'ios' | 'all',
+    buildProfileName: string,
+    buildProfile?: { workflow: Workflow } & object


You could define an interface to avoid using & object.

fson · 2020-09-15T13:43:21Z

packages/config/package.json

+  "bugs": "https://github.com/expo/eas-cli/issues",
+  "dependencies": {
+    "@expo/build-tools": "^0.1.16",
+    "@hapi/joi": "^17.1.1",


I want to be careful with the dependencies we add to EAS CLI so that we don't end up with the same problems as with Expo CLI, which has grown really big. The Joi library seems quite large for just doing object validation (https://packagephobia.com/result?p=%40hapi%2Fjoi), so maybe we can see if there's a more lightweight alternative that we can use.

However, I'm not sure what's the best alternative, https://github.com/vriad/zod is one TypeScript library that I know of, which also can infer the TypeScript types of objects so we don't end up defining everything twice. Maybe see if it would be fit for our purposes? It's almost 50% smaller too.

@expo/build-tools is also using joi internally, rewriting that would require significant changes in turtle code.

For now, build tools contains code that implements all the build process on the worker, but in the future, we will extract types and schemas to separate package.

If size is a big concern maybe ensuring that we don't include multiple versions of the same lib is more important. Maybe some common package with wrappers around those libraries ?

It's important to not include multiple versions of the same lib, but we also need to be careful about choosing libraries, because many library authors don't pay a lot of attention to their dependencies, which makes the library grow big.

#7 will help with this.

EvanBacon · 2020-09-16T15:06:50Z

packages/config/jest.config.js

+  testEnvironment: 'node',
+  testRegex: '/__tests__/.*(test|spec)\\.[jt]sx?$',
+  transform: {
+    '^.+\\.[jt]sx?$': ['babel-jest', { configFile: require.resolve('./babel.config.js') }],


We should move this and the babel config to the root jest/ folder so it can be reused across modules and the babel.config.js won't need to be in each package individually.

I just copied that from eas-cli. I don't really know what would be a better choice here, I leave the decision on that to @fson

Yeah, now that we have two packages let's make them use the same config.

EvanBacon · 2020-09-16T15:11:03Z

packages/config/README.md

@@ -0,0 +1,3 @@
+# @eas/config
+
+A library for interacting with the eas.json


Some thoughts from working on expo/config:

the main reason we added support for app.config.js was because people wanted to configure the publishing and building step dynamically.

We have support for TS/ES support in app.config.js but this is problematic because it makes the package really large and it only works for the config file itself, so if someone were to import a package, that package would need to be transpiled already. So if we do opt for dynamic support I recommend not adding TS/ES support.

I named it config for consistency, but we don't support ts/js, it's only json

wkozyra95 requested a review from fson September 14, 2020 15:10

wkozyra95 commented Sep 14, 2020

View reviewed changes

wkozyra95 force-pushed the @wkozyra95/add-eas-json-support branch from 330ed67 to 650c07d Compare September 15, 2020 10:55

fson reviewed Sep 15, 2020

View reviewed changes

fson changed the base branch from master to main September 16, 2020 09:08

fson mentioned this pull request Sep 16, 2020

Move build and update commands to the core #8

Merged

wkozyra95 force-pushed the @wkozyra95/add-eas-json-support branch from 650c07d to 0ddca6e Compare September 16, 2020 10:10

wkozyra95 marked this pull request as ready for review September 16, 2020 10:12

wkozyra95 requested a review from fson September 16, 2020 10:12

EvanBacon reviewed Sep 16, 2020

View reviewed changes

EvanBacon mentioned this pull request Sep 16, 2020

Move eas.json parsing module from expo-cli #15

Closed

fson approved these changes Sep 17, 2020

View reviewed changes

wkozyra95 force-pushed the @wkozyra95/add-eas-json-support branch from adc1c22 to 2537c36 Compare September 17, 2020 12:52

[@eas/config] add library

779fd4e

wkozyra95 force-pushed the @wkozyra95/add-eas-json-support branch from 2537c36 to dcffb2e Compare September 17, 2020 12:53

extract jest config + rename lib -> build

dcffb2e

wkozyra95 merged commit 728a73d into main Sep 17, 2020

wkozyra95 deleted the @wkozyra95/add-eas-json-support branch October 14, 2020 13:52

byCedric mentioned this pull request Nov 18, 2022

[eas-cli] Split republish command from update command #1533

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[@eas/config] add library #3

[@eas/config] add library #3

wkozyra95 commented Sep 14, 2020

wkozyra95 Sep 14, 2020

fson left a comment

fson Sep 15, 2020

fson Sep 15, 2020

fson Sep 15, 2020

wkozyra95 Sep 15, 2020

wkozyra95 Sep 15, 2020 •

edited

Loading

fson Sep 16, 2020

EvanBacon Sep 16, 2020

wkozyra95 Sep 16, 2020

fson Sep 17, 2020

EvanBacon Sep 16, 2020

wkozyra95 Sep 16, 2020 •

edited

Loading

		@@ -0,0 +1,3 @@
		# @eas/config

		A library for interacting with the eas.json


		jest.mock('fs-extra');

		describe('eas.json', () => {

[@eas/config] add library #3

[@eas/config] add library #3

Conversation

wkozyra95 commented Sep 14, 2020

Choose a reason for hiding this comment

fson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wkozyra95 Sep 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wkozyra95 Sep 16, 2020 • edited Loading

Choose a reason for hiding this comment

wkozyra95 Sep 15, 2020 •

edited

Loading

wkozyra95 Sep 16, 2020 •

edited

Loading