Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build and update commands to the core #8

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Conversation

fson
Copy link
Contributor

@fson fson commented Sep 16, 2020

Move build:* and update:* command placeholders to the eas-cli core package. Remove webhook:* placeholders.

Why?

Plugins are a useful feature of oclif, they can be used to create extensions to the CLI that can be installed separately even if they're not a part of the default installation and to even share commands between many CLIs. They're also a way to split a CLI into modular components.

However, build and update commands should be in the core package and not be separate plugins (at least for the time being), because:

  • These are core functionality that's included in the CLI by default, they're not "add-ons".
  • Having them as separate packages adds unnecessary maintenance overhead (more configuration, more packages to publish) and slows down tools like tsc.
  • We can create libraries like @eas/config for functionality that's shared between packages.

I'm also removing the webhook:* command stubs for now. I added them as examples initially, but currently I'm not certain, if we need to have these commands for editing webhooks, as a website UI seems like a better experience for this task.

@fson fson requested a review from byCedric September 16, 2020 09:49
Copy link
Member

@byCedric byCedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think this is a good way forward, let's do it! I'm not sure if we fully benefit from the composability of OCLIF, but we can change it later if we want or need it. 😄

@fson fson merged commit fdb61ee into main Sep 16, 2020
@dsokal dsokal deleted the @fson/reduce-plugins branch September 7, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants