Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog bot: commit as last commit author #680

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Oct 8, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

Follow up to #676
I've realized that if we commit as @expo-ci then this user appears as the co-author of the commit when the PR gets merged.
Screenshot 2021-10-08 at 16 33 43

How

Commit CHANGELOG.md changes as the last PR commit author.

Test Plan

Tested in the forked repo - https://github.com/dsokal/eas-cli/commits/main

Compare the first and the other merge commit:
Screenshot 2021-10-08 at 16 35 53

@dsokal dsokal requested a review from wkozyra95 October 8, 2021 14:37
@dsokal dsokal merged commit f5d5093 into main Oct 8, 2021
@dsokal dsokal deleted the @dsokal/use-last-commit-author branch October 8, 2021 14:39
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Size Change: -47 B (0%)

Total Size: 22.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 22.5 MB -47 B (0%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants