Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Logging should support %s format #1742

Closed
brentvatne opened this issue Mar 28, 2020 · 1 comment · Fixed by #1799
Closed

Logging should support %s format #1742

brentvatne opened this issue Mar 28, 2020 · 1 comment · Fixed by #1799
Labels
enhancement New feature or request

Comments

@brentvatne
Copy link
Member

brentvatne commented Mar 28, 2020 •
edited

Some logs show up like this:

Warning: %s: Error boundaries should implement getDerivedStateFromError(). In that method, return a state update to display an error message or fallback UI., RootErrorBoundary

I'm not too familiar with how this works in JS but I suspect it's like printf
@byCedric byCedric added the enhancement New feature or request label Mar 30, 2020
@fson fson mentioned this issue Apr 3, 2020
Merged
@fson
Copy link
Contributor

fson commented Apr 6, 2020

We implemented this with @byCedric in #1799.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: handle device logs with format strings (e.g. %s) expo/expo-cli
3 participants
@brentvatne @fson @byCedric