This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

feat: handle device logs with format strings (e.g. %s) #1799

Merged

brentvatne merged 1 commit into master from @fson/sprintf-logs

Apr 7, 2020

Contributor

fson commented Apr 3, 2020

Fixes #1742.


          feat: handle device logs with format strings (e.g. %s)

5a02b97

Co-authored-by: Cedric van Putten <me@bycedric.com>

fson requested a review from brentvatne

April 3, 2020 13:36

fson mentioned this pull request

Logging should support %s format #1742

Closed

brentvatne approved these changes

View reviewed changes

Member

brentvatne commented Apr 7, 2020

nice one! we should probably add tests around logger, worth doing in follow up pr

brentvatne merged commit ccadc2e into master

brentvatne deleted the @fson/sprintf-logs branch

April 7, 2020 01:50

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.