This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[next-adapter] update RNW peer, remove deprecated types #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
reviewed
Apr 9, 2021
|
|
||
| export default function withExpo(nextConfig: NextConfig = {}): NextConfig { | ||
| export default function withExpo(nextConfig: any = {}): any { |
There was a problem hiding this comment.
Can change it in next PR to Record<string, any> if you want, but probably we cannot go more strict than that, without writing the types by hand. 😉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently
@expo/next-adapterlists the outdated version ofreact-native-webin thepeerDependencies.Also the package uses the deprecated and outdate
@types/nextpackage:How
This PR bumps the
react-native-webversion in@expo/next-adapterdependencies to match the one used in Expo environment -0.13.12:It also remove the deprecated and unnecessary Next.js types package and ensures that Next
^9is used in the workspace. To do that, I had to bump explicitnextdev dependency indev-tools, otherwise dependency was always resolved to^8.0.0which do not includes types and was a miss-match for most ofpeerDependencieslisted in other packages.Unfortunately, currently there are no good build-in types for
NextConfig- vercel/next.js#10254.Also as seen below Next.js don't care about that and uses
any🤷♂️CC: @EvanBacon
Test Plan
Command
yarn&&yarn buildexecuted on workspace and in@expo/next-adapterpackage works correctly.