[prebuild config] Created android splash plugin #3576
Conversation
packages/prebuild-config/src/plugins/unversioned/expo-splash-screen/withAndroidSplashImages.ts
Outdated
Show resolved
Hide resolved
packages/prebuild-config/src/plugins/unversioned/expo-splash-screen/withAndroidSplashImages.ts
Outdated
Show resolved
Hide resolved
.../prebuild-config/src/plugins/unversioned/expo-splash-screen/withAndroidSplashMainActivity.ts
Outdated
Show resolved
Hide resolved
| if (config.androidStatusBar?.backgroundColor) { | ||
| if (backgroundColor.toLowerCase() !== config.androidStatusBar?.backgroundColor.toLowerCase()) { | ||
| if (backgroundColor !== config.androidStatusBar?.backgroundColor.toLowerCase()) { |
There was a problem hiding this comment.
looks like the backgroundColor is from app config, do we ensure this is in lowercase?
besides, the backgroundColor is verified by schema /^#|(#)\\d{6}$/
https://github.com/expo/universe/blob/266e38e4b1edb23cd9c7297c3219814c490f7937/server/www/xdl-schemas/UNVERSIONED-schema.json#L46
i am getting a little confused from this regexp, though i know is from a historical code.
/^#|(#)\\d{6}$/.test('#HelloWorld') === trueThere was a problem hiding this comment.
I don't think the validation matters too much here (or for this PR). Android allows lots of different types of colors in the colors.xml file.
There was a problem hiding this comment.
that makes sense, thanks for the classification.
.../prebuild-config/src/plugins/unversioned/expo-splash-screen/withAndroidSplashMainActivity.ts
Show resolved
Hide resolved
| if (config.android?.splash) { | ||
| const splash = config.android?.splash; | ||
| return { | ||
| // TODO: Does this not support `image`? |
There was a problem hiding this comment.
it kinda does, i believe, but if you provide an image that is too large it could crash the app on low end devices
Why
expo/configure-splash-screenand use static mods for introspection. Resolves ENG-79How
android.colorsNightto handleandroid/app/src/main/res/values-night/colors.xmlAdded pseudo support for undocumented props:
{ "android": { "splash": { "mdpi": "./assets/splash/light/mdpi.png", "hdpi": "./assets/splash/light/hdpi.png", "xhdpi": "./assets/splash/light/xhdpi.png", "xxhdpi": "./assets/splash/light/xxhdpi.png", "xxxhdpi": "./assets/splash/light/xxxhdpi.png", "backgroundColor": "#0000ff", "resizeMode": "native", "dark": { "mdpi": "./assets/splash/dark/mdpi.png", "hdpi": "./assets/splash/dark/hdpi.png", "xhdpi": "./assets/splash/dark/xhdpi.png", "xxhdpi": "./assets/splash/dark/xxhdpi.png", "xxxhdpi": "./assets/splash/dark/xxxhdpi.png", "backgroundColor": "#FF00ff" } } } } }Test images:
splash.zip
Test Plan