Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[expo cli] refactor export command #3794

Merged
merged 19 commits into from Aug 31, 2021
Merged

[expo cli] refactor export command #3794

merged 19 commits into from Aug 31, 2021

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Aug 24, 2021 •
edited

Why

The export command is hardcoded to running two platforms at once, this PR refactors the export command to allow for any set of platforms.

While I was adding this feature I figured I'd refactor the entire command since it's large, and difficult to test.

Future Work

  • Combine the publish command with the export command.
  • Move source map, asset, bundle modifications into expo/dev-server / bundler implementation.
  • Create a version that doesn't hash assets.

Test Plan

  • unit test

@EvanBacon EvanBacon requested a review from jkhales August 24, 2021 04:59
jkhales
jkhales approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@jkhales jkhales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! ✨

packages/xdl/src/project/createBundlesAsync.ts Outdated Show resolved Hide resolved
packages/xdl/src/project/publishAsync.ts Show resolved Hide resolved
packages/expo-cli/src/commands/utils/truncateLastLinesAsync.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/export/exportAppAsync.ts Show resolved Hide resolved
packages/expo-cli/src/commands/export/exportAppAsync.ts Show resolved Hide resolved
packages/expo-cli/src/commands/export/exportAppAsync.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/export/exportAppAsync.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/export/exportAppAsync.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/eject/platformOptions.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/eject/platformOptions.ts Outdated Show resolved Hide resolved
@EvanBacon EvanBacon marked this pull request as ready for review August 27, 2021 01:02
ide
ide reviewed Aug 27, 2021
View reviewed changes
packages/xdl/src/project/createBundlesAsync.ts Outdated Show resolved Hide resolved
packages/xdl/src/ProjectAssets.ts Outdated Show resolved Hide resolved
packages/xdl/src/ProjectAssets.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/utils/validateDependenciesVersions.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/utils/truncateLastLinesAsync.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/export/writeContents.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/export/exportAppAsync.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/eject/updatePackageJson.ts Outdated Show resolved Hide resolved
packages/config/src/Config.ts Outdated Show resolved Hide resolved
packages/expo-cli/src/commands/eject/setupWarnings.ts Outdated Show resolved Hide resolved
ide
ide approved these changes Aug 28, 2021
View reviewed changes
packages/expo-cli/src/commands/export.ts Outdated Show resolved Hide resolved
packages/xdl/src/project/createBundlesAsync.ts Outdated Show resolved Hide resolved
@EvanBacon EvanBacon merged commit bdc2e44 into master Aug 31, 2021
@EvanBacon EvanBacon deleted the @evanbacon/expo-cli/export/platform-support branch August 31, 2021 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ide ide ide approved these changes

@jkhales jkhales jkhales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expo export support plaform configuration in config
3 participants
@EvanBacon @ide @jkhales