Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[dev-server][xdl] suppress remote debugging EISDIR error #3889

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

Kudo
Copy link
Collaborator

@Kudo Kudo commented Oct 6, 2021

Why

facebook/react-native#28844
Close ENG-2007

How

prepending a middleware in metro and return 404 for /debugger-ui/*.map requests

Test Plan

initialize a sdk43 project. launch app, enable remote debugging and open inspector. seeing if there are EISDIR errors.

@linear
Copy link

linear bot commented Oct 6, 2021

ENG-2007 Thrown error in expo-cli when remote debugging is enabled

Error: EISDIR: illegal operation on a directory, read
    at Object.readSync (node:fs:723:3)
    at tryReadSync (node:fs:433:20)
    at Object.readFileSync (node:fs:479:19)
    at UnableToResolveError.buildCodeFrameMessage (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:347:17)
    at new UnableToResolveError (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:333:35)
    at ModuleResolver.resolveDependency (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:211:15)
    at DependencyGraph.resolveDependency (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph.js:413:43)
    at /Users/wschurman/temp/qawat/node_modules/metro/src/lib/transformHelpers.js:317:42
    at /Users/wschurman/temp/qawat/node_modules/metro/src/Server.js:1471:14
    at Generator.next (<anonymous>)
Error: EISDIR: illegal operation on a directory, read
    at Object.readSync (node:fs:723:3)
    at tryReadSync (node:fs:433:20)
    at Object.readFileSync (node:fs:479:19)
    at UnableToResolveError.buildCodeFrameMessage (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:347:17)
    at new UnableToResolveError (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:333:35)
    at ModuleResolver.resolveDependency (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:211:15)
    at DependencyGraph.resolveDependency (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph.js:413:43)
    at /Users/wschurman/temp/qawat/node_modules/metro/src/lib/transformHelpers.js:317:42
    at /Users/wschurman/temp/qawat/node_modules/metro/src/Server.js:1471:14
    at Generator.next (<anonymous>)
Error: EISDIR: illegal operation on a directory, read
    at Object.readSync (node:fs:723:3)
    at tryReadSync (node:fs:433:20)
    at Object.readFileSync (node:fs:479:19)
    at UnableToResolveError.buildCodeFrameMessage (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:347:17)
    at new UnableToResolveError (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:333:35)
    at ModuleResolver.resolveDependency (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:211:15)
    at DependencyGraph.resolveDependency (/Users/wschurman/temp/qawat/node_modules/metro/src/node-haste/DependencyGraph.js:413:43)
    at /Users/wschurman/temp/qawat/node_modules/metro/src/lib/transformHelpers.js:317:42
    at /Users/wschurman/temp/qawat/node_modules/metro/src/Server.js:1471:14
    at Generator.next (<anonymous>)

Repro:

  1. Init blank app
  2. expo start
  3. enable remote debugging
  4. see error above in expo-cli

@Kudo Kudo requested a review from EvanBacon October 7, 2021 00:31
Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kudo Kudo force-pushed the @kudo/suppress-remote-debugging-error branch from 0f79a8b to 09a3f41 Compare October 19, 2021 01:02
@Kudo Kudo merged commit 7874392 into master Oct 19, 2021
@Kudo Kudo deleted the @kudo/suppress-remote-debugging-error branch October 19, 2021 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants