This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[plist] Update xmldom for security reasons #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Improperly Controlled Modification of Object Prototype Attributes ('Prototype Pollution') in @xmldom/xmldom and xmldom · CVE-2022-37616 · GitHub Advisory Database](GHSA-9pgh-qqpf-7wqj)
`@xmldom/xmldom` has already been patched:
[fix: Avoid iterating over prototype properties by karfau · Pull Request expo#437 · xmldom/xmldom](xmldom/xmldom#437)
newer versions exist but this is the latest patch version and there shoudln't be any breaking changes
`yarn build` and `yarn test`
EvanBacon
approved these changes
Oct 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Improperly Controlled Modification of Object Prototype Attributes ('Prototype Pollution') in @xmldom/xmldom and xmldom · CVE-2022-37616 · GitHub Advisory Database
Fixes #4569
How
@xmldom/xmldomhas already been patched:fix: Avoid iterating over prototype properties by karfau · Pull Request #437 · xmldom/xmldom
newer versions exist but this is the latest patch version and there shouldn't be any breaking changes
Test Plan
yarn buildandyarn test