This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] Advise to use new doctor on SDK 46+ #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CX-223 In global Expo CLI tell people about new doctor when they run old command
For SDK versions supported by the new doctor, let developers know to run that command instead and exit. |
keith-kurak
deleted the
keith/cx-223-in-global-expo-cli-tell-people-about-new
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fulfills https://linear.app/expo/issue/CX-223/in-global-expo-cli-tell-people-about-new-doctor-when-they-run-old
How
Added an error log and exited when SDK Version >= 46
Test Plan
Tested on SDK 46+, errored out:
Proceeded as before when SDK 45 is installed.