This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
refactor(json-file): move to expo/expo
#4782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
byCedric
added a commit
to expo/expo
that referenced
this pull request
Nov 23, 2023
# Why This package is used in various places [within this monorepo](https://github.com/search?q=repo%3Aexpo%2Fexpo%20%40expo%2Fjson-file%20path%3A**%2Fpackage.json&type=code). The clean-up PR is here: expo/expo-cli#4782 # How - Moved `@expo/json-file` from `expo/expo-cli`. - Added missing `devDependencies` relation to `expo-module-scripts` - Updated `jest.config.js`, and `package.json` - Building with TSC, not with babel, so dropped `babel.config.js` # Test Plan See if CI passes. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why This package is used in various places [within this monorepo](https://github.com/search?q=repo%3Aexpo%2Fexpo%20%40expo%2Fjson-file%20path%3A**%2Fpackage.json&type=code). The clean-up PR is here: expo/expo-cli#4782 # How - Moved `@expo/json-file` from `expo/expo-cli`. - Added missing `devDependencies` relation to `expo-module-scripts` - Updated `jest.config.js`, and `package.json` - Building with TSC, not with babel, so dropped `babel.config.js` # Test Plan See if CI passes. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This package is actively used, and should exist in
expo/expo.How
See expo/expo#25405
Test Plan
See if CI passes.