Skip to content

Commit

Permalink
[expo] Fix lottie import issue (#19613)
Browse files Browse the repository at this point in the history
# Why

fix android unversioned qa issue for sdk 47

# How

as #19439, but another name 😅
lottie actually doesn't get native stuff from `NativeModules` but `UIManager.getViewManagerConfig`. they're all false alarms from react-native-safe-module.

# Test Plan

unversioned expo go + NCL lottie
  • Loading branch information
Kudo committed Oct 19, 2022
1 parent 04819bf commit b98acac
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/expo/build/proxies/NativeModules.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions packages/expo/build/proxies/NativeModules.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo/build/proxies/NativeModules.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/expo/src/proxies/NativeModules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ const PROPS_TO_IGNORE: Set<string> = new Set([
'RNGetRandomValues',
'RNVectorIconsManager',
'RNVectorIconsModule',
'LottieAnimationViewManager', // False alarm from lottie where it uses react-native-safe-module to detect corresponding native module, but it doesn't exist in lottie.
// False alarm from lottie where it uses react-native-safe-module to detect corresponding native module, but it doesn't exist in lottie.
'LottieAnimationViewManager',
'LottieAnimationView',
/**
* Other methods that can be called on the NativeModules object that we should ignore. The
* underlying NativeModules object is sometimes a proxy itself so may not have these methods
Expand Down

0 comments on commit b98acac

Please sign in to comment.