Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo] Fix LottieAnimationViewManager not found error #19439

Merged
merged 2 commits into from Oct 7, 2022

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Oct 6, 2022

Why

How

lottie-react-native uses react-native-safe-module to detect corresponding native module. however, lottie doesn't have a native module. it's a false alarm for module detection. this pr adds the LottieAnimationViewManager to the exclusion list.

Test Plan

  • NCL lottie

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 6, 2022
@Kudo Kudo marked this pull request as ready for review October 6, 2022 19:01
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 6, 2022
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still very very concerned that the entire proxy and throwing an error will break a lot more things and we'll regret it

@Kudo
Copy link
Contributor Author

Kudo commented Oct 7, 2022

I'm still very very concerned that the entire proxy and throwing an error will break a lot more things and we'll regret it

my thought is more about giving this a taste since it helps for the transition from expo go to dev builds. if there are any problems, users could disable it by import 'expo/disable-missing-native-module-errors';. this is described in the fyi page. in the long run, we could also stabilize the exclusion list.

let's keep eyes on it 👀 and i'm going to merge this first 😅

@Kudo Kudo merged commit 5ab8ac2 into main Oct 7, 2022
@Kudo Kudo deleted the @kudo/sdk47/fix-lottie-view-manager-error branch October 7, 2022 02:53
@brentvatne
Copy link
Member

i'm also a bit concerned but let's see how it goes during the beta and we can decide how to proceed given the feedback we receive

@Kudo Kudo mentioned this pull request Oct 19, 2022
3 tasks
Kudo added a commit that referenced this pull request Oct 19, 2022
# Why

fix android unversioned qa issue for sdk 47

# How

as #19439, but another name 😅
lottie actually doesn't get native stuff from `NativeModules` but `UIManager.getViewManagerConfig`. they're all false alarms from react-native-safe-module.

# Test Plan

unversioned expo go + NCL lottie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants