Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios][dev-client] Regression with SDK 47 and UIViewControllerBasedStatusBarAppearance #20047

Closed
hirbod opened this issue Nov 14, 2022 · 0 comments · Fixed by #20104
Closed

[ios][dev-client] Regression with SDK 47 and UIViewControllerBasedStatusBarAppearance #20047

hirbod opened this issue Nov 14, 2022 · 0 comments · Fixed by #20104
Labels
Development Builds needs validation Issue needs to be validated

Comments

@hirbod
Copy link
Contributor

hirbod commented Nov 14, 2022

Summary

I am using react-native-screens status bar management. Therefore I have to set UIViewControllerBasedStatusBarAppearance to YES.

This issue was fixed in SDK 44 or 45 but has been reintroduced now. Afaik, no imports of StatusBar are allowed.

My dev client crashes when I try to login with Expo (crash happens as soon as I tap the sign in button top right)

IMG_1899

Managed or bare workflow?

bare

What platform(s) does this occur on?

iOS

Package versions

expo-dev-client ~2.0.0
expo-updates ~0.15.4

Environment

  expo-env-info 1.0.5 environment info:
    System:
      OS: macOS 12.6
      Shell: 5.8.1 - /bin/zsh
    Binaries:
      Node: 14.20.0 - ~/.nvm/versions/node/v14.20.0/bin/node
      Yarn: 3.2.4 - ~/.nvm/versions/node/v14.20.0/bin/yarn
      npm: 9.1.1 - ~/.nvm/versions/node/v14.20.0/bin/npm
      Watchman: 2022.03.21.00 - /usr/local/bin/watchman
    Managers:
      CocoaPods: 1.11.2 - /usr/local/bin/pod
    SDKs:
      iOS SDK:
        Platforms: DriverKit 22.1, iOS 16.1, macOS 13.0, tvOS 16.1, watchOS 9.1
    IDEs:
      Android Studio: 2021.2 AI-212.5712.43.2112.8512546
      Xcode: 14.1/14B47b - /usr/bin/xcodebuild
    npmGlobalPackages:
      eas-cli: 0.59.0
      expo-cli: 6.0.8
    Expo Workflow: bare

Reproducible demo

Add this to your expo config:

    expo.ios.infoPlist: {
      UIViewControllerBasedStatusBarAppearance: true,
    }

Stacktrace (if a crash is involved)

No response

@hirbod hirbod added Development Builds needs validation Issue needs to be validated labels Nov 14, 2022
lukmccall added a commit that referenced this issue Nov 21, 2022
…ewControllerBasedStatusBarAppearance` to be false (#20104)

# Why

Fixes #20047.

# How

Made sure that `StatusBar` won't be imported by any dev-client code. 

# Test Plan

- bare-expo ✅
- simple app outside of the expo/expo repo
lukmccall added a commit that referenced this issue Nov 21, 2022
…ewControllerBasedStatusBarAppearance` to be false (#20104)

Fixes #20047.

Made sure that `StatusBar` won't be imported by any dev-client code.

- bare-expo ✅
- simple app outside of the expo/expo repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development Builds needs validation Issue needs to be validated
Projects
None yet
1 participant