Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-client] Fix RCTStatusBarManager module requires that the UIViewControllerBasedStatusBarAppearance to be false #20104

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

lukmccall
Copy link
Contributor

Why

Fixes #20047.

How

Made sure that StatusBar won't be imported by any dev-client code.

Test Plan

  • bare-expo ✅
  • simple app outside of the expo/expo repo

…ewControllerBasedStatusBarAppearance` to be false
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Nov 18, 2022
@lukmccall lukmccall merged commit 3e3ca02 into main Nov 21, 2022
@lukmccall lukmccall deleted the @lukmccall/dev-client/fixed-status-bar branch November 21, 2022 10:03
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Nov 21, 2022
lukmccall added a commit that referenced this pull request Nov 21, 2022
…ewControllerBasedStatusBarAppearance` to be false (#20104)

Fixes #20047.

Made sure that `StatusBar` won't be imported by any dev-client code.

- bare-expo ✅
- simple app outside of the expo/expo repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ios][dev-client] Regression with SDK 47 and UIViewControllerBasedStatusBarAppearance
3 participants