Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine if we can skip background mode check when using Geofencing #5054

Closed
AdamJNavarro opened this issue Jul 23, 2019 · 0 comments · Fixed by #5198
Closed

Determine if we can skip background mode check when using Geofencing #5054

AdamJNavarro opened this issue Jul 23, 2019 · 0 comments · Fixed by #5198
Assignees
@tsapeta
Labels
Location

Comments

@AdamJNavarro
Copy link
Contributor

Related post: https://forums.expo.io/t/ios-app-store-rejections-with-the-location-background-mode/25537/2

If possible, we should remove the check for background mode enabled if the user is just using the Geofencing API
@tsapeta tsapeta mentioned this issue Aug 6, 2019
Merged
tsapeta added a commit that referenced this issue Aug 6, 2019
@tsapeta
[location][ios] Fix location background mode was required to use geof…
d59e175 
…encing (#5198)

# Why

Fixes #5054 

# How

I removed checks for `location` background mode when starting/stoping geofencing.

# Test Plan

Should work 😅
tsapeta added a commit that referenced this issue Aug 6, 2019
@tsapeta
[location][ios] Fix location background mode was required to use geof…
57b5fee 
…encing (#5198)

Fixes #5054

I removed checks for `location` background mode when starting/stoping geofencing.

Should work 😅
@lock lock bot added the outdated label Feb 2, 2020
@lock lock bot locked and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tsapeta tsapeta

Labels
Location
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[location][ios] Fix location background mode was required to use geofencing expo/expo
2 participants
@tsapeta @AdamJNavarro