Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Fabric and Crashlytics #8047

Closed
esamelson opened this issue Apr 27, 2020 · 0 comments · Fixed by #8211
Closed

Remove Fabric and Crashlytics #8047

esamelson opened this issue Apr 27, 2020 · 0 comments · Fixed by #8211
Assignees
@tsapeta
Labels
Android iOS
Projects
SDK 38

Comments

@esamelson
Copy link
Contributor

Google is shutting down Fabric May 5: http://fabric.io/blog/fabric-shutdown-extension/. We currently use Fabric/Crashlytics in the Expo client, and the Crashlytics library is embedded in standalone apps on both platforms. We think existing clients won't break since that'd be crazy, but we should remove all Fabric libraries from both Expo clients and all standalone apps going forward.

We don't need to migrate our existing crash logs from Fabric to Firebase. We haven't looked at this data in years anyway.

  • Testing

    • Make sure to test both development clients and ensure they don't send network requests to Fabric/Crashlytics. The binaries should not include any Fabric/Crashlytics code.
    • When it's time to do the release, make sure to test managed standalone apps (Turtle builds) and ExpoKit projects and verify these same two things.

  • If we want to add back crash logging, let's use our existing Firebase project and include the code only in the app store development clients.

    • We currently include Crashlytics in all managed apps, which we don't want to do anymore. Developers should use the bare workflow if they want Firebase crash logging.
    • This step isn't strictly necessary, since we haven't been looking at that data. Timebox a short amount of time for this (0-1 days probably) and otherwise we'll just do it later on.
@tsapeta tsapeta self-assigned this Apr 28, 2020
@tsapeta tsapeta mentioned this issue May 5, 2020
Merged
tsapeta added a commit that referenced this issue May 6, 2020
@tsapeta
[ios][et] Remove Fabric and Crashlytics on iOS (#8160)
b8e86ac 
# Why

Part of #8047 - not closing yet because I'm gonna make separate PR for Android.

# How

I removed:
- Fabric and Crashlytics from `Podfile` and run `pod install`.
- code calling Fabric & Crashlytics libraries.
- `et ios-run-fabric` command and its `run-fabric.sh` build phase in general.
- modifying `Info.plist` while generating dynamic macros, it was used only to apply fabric's api key.
- `et ios-cleanup-dynamic-macros` command - no longer needed if we don't modify `Info.plist`.
- Fabric's key from `Info.plist`.

## Side notes

Previously, once Crashlytics detects a crash, we set a flag in user defaults and then if that flag is set we invalidated cached kernel's bundle. After these changes, kernel's bundle won't be invalidated. I chatted with James and he agrees that we actually don't need this anymore.

# Test Plan

Xcode project builds and works as expected.
@tsapeta tsapeta mentioned this issue May 8, 2020
Merged
@tsapeta tsapeta added this to Done in SDK 38 via automation May 8, 2020
tsapeta added a commit that referenced this issue May 8, 2020
@tsapeta
[android] Remove Fabric and Crashlytics on Android (#8211)
6a72752 
# Why

Closes #8047 

# How

I removed:
- Fabric and Crashlytics setup
- `FABRIC_API_KEY` and `FABRIC_SECRET_KEY` from secrets keys
- `fabric.properties` files
- Removed Fabric and Crashlytics files from cluttered `.gitignore` files

# Test Plan

CI jobs passed, Android's client builds and works as expected.
Jamedjo pushed a commit to Jamedjo/expo that referenced this issue Feb 4, 2021
@tsapeta
[android] Remove Fabric and Crashlytics on Android (expo#8211)
fce6527 
# Why

Closes expo#8047 

# How

I removed:
- Fabric and Crashlytics setup
- `FABRIC_API_KEY` and `FABRIC_SECRET_KEY` from secrets keys
- `fabric.properties` files
- Removed Fabric and Crashlytics files from cluttered `.gitignore` files

# Test Plan

CI jobs passed, Android's client builds and works as expected.
prakashbask pushed a commit to prakashbask/expo that referenced this issue Mar 16, 2022
@tsapeta
[android] Remove Fabric and Crashlytics on Android (expo#8211)
3b87698 
# Why

Closes expo#8047 

# How

I removed:
- Fabric and Crashlytics setup
- `FABRIC_API_KEY` and `FABRIC_SECRET_KEY` from secrets keys
- `fabric.properties` files
- Removed Fabric and Crashlytics files from cluttered `.gitignore` files

# Test Plan

CI jobs passed, Android's client builds and works as expected.
gurs1kh pushed a commit to gurs1kh/expo that referenced this issue Jan 18, 2024
@tsapeta
[android] Remove Fabric and Crashlytics on Android (expo#8211)
66fb9bc 
# Why

Closes expo#8047 

# How

I removed:
- Fabric and Crashlytics setup
- `FABRIC_API_KEY` and `FABRIC_SECRET_KEY` from secrets keys
- `fabric.properties` files
- Removed Fabric and Crashlytics files from cluttered `.gitignore` files

# Test Plan

CI jobs passed, Android's client builds and works as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsapeta tsapeta

Labels
Android iOS
Projects
No open projects
SDK 38
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[android] Remove Fabric and Crashlytics on Android expo/expo
2 participants
@tsapeta @esamelson