[android] Remove Fabric and Crashlytics on Android #8211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
tsapeta
requested review from
bbarthec,
brentvatne,
esamelson,
EvanBacon,
ide,
IjzerenHein,
lukmccall,
mczernek and
sjchmiela
as code owners
ide
approved these changes
May 8, 2020
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
# Why Closes expo#8047 # How I removed: - Fabric and Crashlytics setup - `FABRIC_API_KEY` and `FABRIC_SECRET_KEY` from secrets keys - `fabric.properties` files - Removed Fabric and Crashlytics files from cluttered `.gitignore` files # Test Plan CI jobs passed, Android's client builds and works as expected.
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
# Why Closes expo#8047 # How I removed: - Fabric and Crashlytics setup - `FABRIC_API_KEY` and `FABRIC_SECRET_KEY` from secrets keys - `fabric.properties` files - Removed Fabric and Crashlytics files from cluttered `.gitignore` files # Test Plan CI jobs passed, Android's client builds and works as expected.
gurs1kh
pushed a commit
to gurs1kh/expo
that referenced
this pull request
Jan 18, 2024
# Why Closes expo#8047 # How I removed: - Fabric and Crashlytics setup - `FABRIC_API_KEY` and `FABRIC_SECRET_KEY` from secrets keys - `fabric.properties` files - Removed Fabric and Crashlytics files from cluttered `.gitignore` files # Test Plan CI jobs passed, Android's client builds and works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #8047
How
I removed:
FABRIC_API_KEYandFABRIC_SECRET_KEYfrom secrets keysfabric.propertiesfiles.gitignorefilesTest Plan
CI jobs passed, Android's client builds and works as expected.