[Android] Switch to Android SDK 30 & update gradle #11647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarthec
requested review from
brentvatne,
cruzach,
esamelson,
EvanBacon,
ide,
IjzerenHein,
lukmccall and
tsapeta
as code owners
bbarthec
requested review from
byCedric and
tsapeta
and removed request for
brentvatne,
ide,
tsapeta,
IjzerenHein,
lukmccall,
EvanBacon,
esamelson and
cruzach
tsapeta
approved these changes
Jan 17, 2021
There was a problem hiding this comment.
Looks good! 👍
Have you read this https://developer.android.com/about/versions/11/behavior-changes-11? There might be some behavior changes for Androids below 11 when the app targets 11 🤔
...expo-screen-capture/android/src/main/java/expo/modules/screencapture/ScreenCapturePackage.kt
Show resolved
Hide resolved
bbarthec
changed the title
bbarthec
force-pushed
the
@bbarthec/android/android-sdk-30
branch
from
5068fd4
to
669273d
Compare
|
Native Component List for this branch is ready |
bbarthec
force-pushed
the
@bbarthec/android/android-sdk-30
branch
from
237ff6a
to
8906142
Compare
esamelson
suggested changes
Jan 19, 2021
bbarthec
force-pushed
the
@bbarthec/android/android-sdk-30
branch
2 times, most recently
from
177d5a8
to
127e15e
Compare
Affected packages: - @unimodules/react-native-adapter - expo-av - expo-branch - expo-error-recovery - expo-image-loader - expo-image-picker - expo-in-app-purchases - expo-media-library - expo-notifications - expo-permissions - expo-screen-capture - expo-screen-orientation - expo-splash-screen - expo-store-review - expo-updates - expo-web-browser - unimodules-permissions-interface
bbarthec
force-pushed
the
@bbarthec/android/android-sdk-30
branch
from
127e15e
to
e3b1541
Compare
esamelson
reviewed
Jan 25, 2021
This was referenced Feb 23, 2021
lukmccall
added a commit
that referenced
this pull request
Mar 5, 2021
# Why Followup of #11647. # How Adjust expo-media-library module according to the scoped storage documentation. > **Note:** Those changes were made with compatibility in mind. So not all changes are considered as a best practice on the newest Android. However, some of them may change the behavior of users app. # TODO - [x] Update docs # Test Plan (Tested on a simulator and real device with Android R) - NCL ✅ - test-suite ✅
lukmccall
added a commit
that referenced
this pull request
Mar 6, 2021
# Why Followup of #11647. # How - Handled SAF files in the `expo-file-system`. - Added a way to ask for external storage write permissions. > **Note**: Those changes were needed to ensure a smooth transition to a scoped storage on Android. # Test Plan - NCL ✅
15 tasks
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
# Why We want to switch to Android SDK 30. # How - [x] I've bumped `targetSdkVersion` to `30` - [x] I've bumped `compileSdkVersion` to `30` - [x] I've fixed nullability issues coming from # Test Plan - [x] compiled & run Expo Go on Android SDK 30 simulator - [x] compiled & run `bare-expo` on Android SDK 30 simulator - [x] launched `ncl` in Expo Go and played for a while # CHANGES - [Android] Update gradle to 6.8 & gradlePlugin to 4.1.1 - [Android] Bump targerSdkVersion and compileSdkVersion to 30 - [Android] Bump kotlin plugin version to 1.4.21 - [Android] Fix & unify ANDROID_NDK_HOME path detection - [react-native][Android][submodule update] Rename ANDROID_NDK to ANDROID_NDK_HOME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Why
We want to switch to Android SDK 30.
How
targetSdkVersionto30compileSdkVersionto30Test Plan
bare-expoon Android SDK 30 simulatornclin Expo Go and played for a whileTODOs
CHANGELOGentriesAfter this PR is merged
ncland every test intest-suiteand detect any regressions