[location] remove sticky notification on app killing #11775
Conversation
@lukmccall I think this is |
|
Yes, of course 😅 Sorry my bad |
|
Done @lukmccall |
|
Does this apply to swiping the app closed? |
|
This PR looks like it is braking the background location updates while app is closed/killed. My app was working perfectly fine before this PR (Aug 2020), but after updating expo-location (Aug 2021), background location stopped working. The location updates still work perfectly fine while the app is in background, but not when it is closed/killed. My guess is that the sticky notification was the one that kept the service "alive" even when the app was closed (and by "alive" I mean that location updates keep coming even after I can add a PR pretty quickly if you give me a green light. |
|
@alexbuicescu, you're right. We shouldn't remove the notification. However, I think we should add an option to choose if the notification (and service) will be automatically closed with the app. |
|
I agree with this, the purpose of the stiky notification is keeping the foreground service alive when app is killed so the app can keep receiving location updates, the stinky notification requirement for background location updates was introduced few years ago in Android and it is must if the app requires location updates in background. |
|
@zaguiini In my case notification is being removed as soon as I killed the app. I want sticky notification. What should I do to achieve sticky notification? I am using "expo-location": "12.0.4" |
|
Is this supposed to be a fix ? this is bad . how would we get location updates when app is killed ????????? |
zaguiini
deleted the
remove-location-foreground-notification-on-app-killing
branch
…15633) # Why In order to make background location more felxible we should give a choice to developers whether or not the foreground service should be killed when the app is killed . i personally found this a show stopper . i for example have a cab booking system where i must show the driver that i'm using his location even when he kills his app . Following this PR #11775 i was able to make this optional . # How I've added a boolean option "killServiceOnDestroy" to LocationTaskServiceOptions which will be passed to the LocationTaskService Intent through extra params , if it's true the foreground service will dissapear on app killing . # Test Plan Try starting background location and killing the app from the task manager. if killServiceOnDestroy is true The notification should be destroyed , otherwise it'll stick .
Why
Sticky notification was not being removed when the app was killed.
Some folks are having this problem.
How
I'm not so good at Android development so I'll try my best to explain it. Basically I added a listener to the service stop which allowed to remove the sticky notification from the taskbar.
Test Plan
Try starting background location and killing the app from the task manager. The notification should be destroyed. It doesn't happen like that on the latest published version.