Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash from expo-camera and expo-barcode-scanner #11900

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Feb 10, 2021

Why

lodash is big

How

  • use the reduce function instead.
  • Added missing type for expo-camera native settings FlashMode, AutoFocus, WhiteBalance to match CameraType.

Test Plan

  • Added unit tests to expo-camera

@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@EvanBacon EvanBacon merged commit 62db01f into master Feb 10, 2021
@EvanBacon EvanBacon deleted the @evanbacon/expo-camera/remove-lodash branch February 10, 2021 23:48
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
* Remove lodash from expo-camera

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants