Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Update NetInfo to 5.9.10 #11947

Merged
merged 2 commits into from
Feb 17, 2021
Merged

[ios] Update NetInfo to 5.9.10 #11947

merged 2 commits into from
Feb 17, 2021

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Feb 15, 2021

Why

When testing #11945 I tried upgrading @react-native-community/netinfo, thought I can commit it already.

How

  • et update-module -m @react-native-community/netinfo
  • Removed old NetInfo files from Xcode project
  • There were no changes on Android, so it's just on iOS

Test Plan

Tested against NCL — works fine 👍

@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@tsapeta tsapeta marked this pull request as ready for review February 16, 2021 14:50
@tsapeta tsapeta requested a review from ide as a code owner February 16, 2021 14:50
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tsapeta tsapeta merged commit 6ab0274 into master Feb 17, 2021
@tsapeta tsapeta deleted the @tsapeta/update-netinfo branch February 17, 2021 09:16
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants